From: Rudi Grinberg <rudi.grinberg@gmail.com>
To: "Paul A. Steckler" <steck@stecksoft.com>,
Ocaml Mailing List <caml-list@inria.fr>
Subject: Re: [Caml-list] Porting old-style ppx to driver-style?
Date: Thu, 10 May 2018 14:00:11 +0700 [thread overview]
Message-ID: <m28t8sj8qs.fsf@Rudis-MacBook-Pro.local.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <CAMSKV5fLxsTFyrR1naMSPk_Nb7kEd3dLeeD1eF8T3p7C6YKf7w@mail.gmail.com>
Hi Paul,
> I believe the solution is to turn the ppx into a new-style "driver".
> What's the best way to do that? Is it as simple as changing the build
> to use a jbuild as described in the section "Creating a new Ppx_driver
> based rewriter"?:
Using ppx_driver (now a part of ppxlib I believe) isn't necessary. I
think it should be enough to follow the lead of other ppx_deriving
plugins that are built with dune (ppx_deriving_yojson for example). The
necessary bit here is to use omp and generate a correct META file that
will make ppx_deriving_lens usable in driver *and* as a dynlinked
deriver for ppx_deriving itself.
There's an existing PR to port ocaml-lens and I believe it's on the
right track:
https://github.com/pdonadeo/ocaml-lens/pull/9
Perhaps you can help out with that effort?
Cheers,
Rudi.
next prev parent reply other threads:[~2018-05-10 7:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 22:20 Paul A. Steckler
2018-05-10 7:00 ` Rudi Grinberg [this message]
2018-05-11 1:18 ` Paul A. Steckler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m28t8sj8qs.fsf@Rudis-MacBook-Pro.local.i-did-not-set--mail-host-address--so-tickle-me \
--to=rudi.grinberg@gmail.com \
--cc=caml-list@inria.fr \
--cc=steck@stecksoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox