From: Mikhail Mandrykin <mandrykin@ispras.ru>
To: Ivan Gotovchits <ivg@ieee.org>, Serge Sivkov <ssp.mryau@gmail.com>
Cc: OCaml Mailing List <caml-list@inria.fr>
Subject: Re: [Caml-list] using module with types as record parameter
Date: Tue, 28 Nov 2017 21:19:57 +0300 [thread overview]
Message-ID: <fbb1de08-59a8-52d2-209a-c6056f890ce3@ispras.ru> (raw)
In-Reply-To: <CALdWJ+x4pJNaYtRAwuZACGmFN0XOr5GPTWwpVB-Gc7-ssVWk6w@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3748 bytes --]
It's also possible to parametrize over abstract types (though only those
without type parameters) that occur in first-class module signature:
module type CmdIface = sig
type message
val cmd : message -> int
end
module type NetIface = sig
type init
val net : init -> init
end
module Cmd = struct
type message = int
let cmd v = v+1
end
module Net = struct
type 'a init = { cvt: (module CmdIface with type message = 'a) }
let net (init : int init) =
let cvt = init.cvt in
let (module R) = cvt in
R.cmd 1 (* line 22 with error *)
end
let i = { Net.cvt = (module Cmd) };;
Net.net i;;
Also there's another type error in the example since types of cmd in the
Cmdline module type and Cmd module are incompatible (_ -> unit vs. _ ->
int).
On 28.11.2017 21:09, Ivan Gotovchits wrote:
> Let me first explain what is wrong with your code.
>
> The message type in `Cmdlface` is defined as an abstract type with
> only one operation `cmd : message -> unit`. The module `Cmd` provides
> a possible implementation for this abstract type.
> The `R.cmd 1` expression tries to break the abstraction by assuming
> that the `R` implementation is using the `int` type as an underlying
> implementation. Imagine, what will happen if the `Net.cvt` field
> contained another implementation,
> for example
>
> module Cmd = struct
> type message = string
> let cmd = print_endline
> end
>
> let i = { Net.cvt = (module Cmd: CmdIface) }
> Net.net i
>
> This will finally lead to a call `print_endline 1` if the type system
> won't stop you before.
>
>
> The solution is either to uncover the abstractions and stick to `int`
> as a concrete representation of the message abstraction or to extend
> the message abstraction interface with functions that will allow you
> to create the messages, e.g.,
>
>
> module type CmdIface = sig
> type message
> val of_int : int -> message
> val cmd : message -> unit
> end
>
>
>
>
>
> On Tue, Nov 28, 2017 at 12:55 PM, Serge Sivkov <ssp.mryau@gmail.com
> <mailto:ssp.mryau@gmail.com>> wrote:
>
> Hello,
>
> is there way to fix the following code:
>
> module type CmdIface = sig
> type message
> val cmd : message -> unit
> end
>
> module type NetIface = sig
> type init
> val net : init -> init
> end
>
> module Cmd = struct
> type message = int
> let cmd v = v+1
> end
>
> module Net = struct
> type init = { cvt: (module CmdIface) }
>
> let net init =
> let cvt = init.cvt in
> let module R = (val cvt: CmdIface) in
> R.cmd 1 (* line 22 with error *)
> end
>
> let i = { Net.cvt = (module Cmd: CmdIface) }
> Net.net i
>
> I got error:
> File "t.ml <http://t.ml>", line 22, characters 22-23:
> Error: This expression has type int but an expression was expected
> of type
> R.message
>
> In case I do not use types in function signature code works well:
> module type I = sig val f : int -> int end;;
> module M = struct
> let f v = v+1
> end;;
> type t = {cvt: (module M); v: int};;
> let module R = (val i.cvt: I) in R.f i.v;;
> - : int = 1
>
> WBR, ssp
>
>
--
Mikhail Mandrykin
Linux Verification Center, ISPRAS
web: http://linuxtesting.org
e-mail: mandrykin@ispras.ru
[-- Attachment #2: Type: text/html, Size: 8161 bytes --]
prev parent reply other threads:[~2017-11-28 18:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 17:55 Serge Sivkov
2017-11-28 18:09 ` Ivan Gotovchits
2017-11-28 18:19 ` Mikhail Mandrykin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbb1de08-59a8-52d2-209a-c6056f890ce3@ispras.ru \
--to=mandrykin@ispras.ru \
--cc=caml-list@inria.fr \
--cc=ivg@ieee.org \
--cc=ssp.mryau@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox