Mailing list for all users of the OCaml language and system.
 help / color / mirror / Atom feed
From: "Evan Klitzke" <evan@yelp.com>
To: peng.zang@gmail.com
Cc: caml-list@inria.fr
Subject: Re: [Caml-list] Help with simple ocaml memoization problem
Date: Wed, 28 Nov 2007 22:12:57 -0800	[thread overview]
Message-ID: <cfb58d850711282212r64eddad3u713e2eb743526b0a@mail.gmail.com> (raw)
In-Reply-To: <200711290053.15443.peng.zang@gmail.com>

On 11/28/07, Peng Zang <peng.zang@gmail.com> wrote:
> I don't know how to increase the stack size off the top of my head, but in
> general you want to avoid recursion on the stack anyways.  An easy way is to
> simply make the function tail recursive so the compiler can optimized it into
> a loop for you.  Here's a pretty faithful replication of your python code.
> Note I use Int64 instead of BigInt as I'm running OCaml 3.09.3.
>
> let ( ++ ) = Int64.add;;
> let ( ** ) = Int64.mul;;
> let ( %% ) = Int64.rem;;
> let ( // ) = Int64.div;;
> let l1 = Int64.of_int 1;;
> let l2 = Int64.of_int 2;;
> let l3 = Int64.of_int 3;;
> let cache = Hashtbl.create 1000000;;
>
> let collatz = function
>   | x when x %% l2 = l1 -> l3 ** x ++ l1
>   | x -> x // l2
> ;;
> let rec find_collatz_len = function
>   | x when x = l1 -> l1
>   | x when Hashtbl.mem cache x -> Lazy.force (Hashtbl.find cache x)
>   | x -> let ans = lazy (l1 ++ find_collatz_len (collatz x)) in
>       Hashtbl.add cache x ans;
>       Lazy.force ans
> ;;
> let lengths = Array.init 999999
>   (fun x -> let x = Int64.of_int (x+1) in (x, find_collatz_len x));;
> Array.sort (fun (a,b) (c,d) -> compare d b) lengths;;
> lengths.(0);;
>
>
> The use of laziness here is just so I can put the recursive call in the tail
> position -- a quick hack because I'm too lazy to spend time making it into a
> loop myself.
>
> There should really be some easy syntax to write BigInts or Int64s directly in
> the code.  Is there some camlp4 that does this somewhere?  And it would nice
> if Int64 operators were predefined in the module.

Thanks Peng. This is much easier to grok than the code that I
originally wrote! One question that I have is what is the difference
between the Map and Hashtbl modules? From the documentation they look
very similar -- why did you use Hashtbl here rather than Map?

-- 
Evan Klitzke <evan@yelp.com>


  reply	other threads:[~2007-11-29  6:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-29  3:17 Evan Klitzke
2007-11-29  5:53 ` [Caml-list] " Peng Zang
2007-11-29  6:12   ` Evan Klitzke [this message]
2007-11-29  8:16     ` David Allsopp
2007-11-29  8:11       ` Jon Harrop
2007-11-29  8:58         ` Jean-Christophe Filliâtre
2007-11-29 18:57           ` Jon Harrop
2007-11-29 22:25           ` Jon Harrop
2007-11-30 11:03             ` Jean-Christophe Filliâtre
2007-11-29  8:40       ` Luc Maranget
2007-11-29  8:47     ` Jean-Christophe Filliâtre
2007-12-04 23:49     ` Peng Zang
2007-11-29  8:08   ` Jon Harrop
2007-11-29 15:59     ` Peng Zang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cfb58d850711282212r64eddad3u713e2eb743526b0a@mail.gmail.com \
    --to=evan@yelp.com \
    --cc=caml-list@inria.fr \
    --cc=peng.zang@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox