From: Jon Kleiser <jon.kleiser@ceres.no>
To: "caml-list@inria.fr" <caml-list@inria.fr>
Subject: Re: [Caml-list] Create Array of floats from string
Date: Thu, 27 Apr 2017 09:15:52 +0000 [thread overview]
Message-ID: <E7AA81E4-D690-4F8F-8C22-87F5CF9575D8@mail.uio.no> (raw)
In-Reply-To: <e0fd4e8d-246b-e534-9153-e2097579673c@lexifi.com>
I now adjusted my code to ignore the space at the end of each input line, and using
String.split_on_char ' ' line
instead of
Str.split (Str.regexp " ") line
speeds up my program from taking 25.8 secs to now only 17.4 secs. That’s quite a bit. Thanks, Alain!
/Jon
> On 26. Apr, 2017, at 17:27, Alain Frisch <alain.frisch@lexifi.com> wrote:
>
> On 26/04/2017 12:48, Jon Kleiser wrote:
>> let make_vector vec_strings =
>> let vec = Array.make !dims 0.0 in
>> List.iteri (fun i str -> vec.(i) <- float_of_string str) vec_strings
>>
>> let process_line line =
>> let parts = Str.split (Str.regexp " ") line in
>> make_vector (List.tl parts) (* skipping first element which is not a float *)
>
> Since OCaml 4.04, you have:
>
> let parts = String.split_on_char ' ' line in
>
> -- Alain
next prev parent reply other threads:[~2017-04-27 9:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 10:48 Jon Kleiser
2017-04-26 11:02 ` rixed
2017-04-26 13:36 ` Francois BERENGER
[not found] ` <CAPFanBGh0q2AaF7ROWJJF81o=8+79sn-q4-CxqCKGQ__Oa5SEw@mail.gmail.com>
2017-04-26 14:05 ` Jon Kleiser
2017-04-26 15:26 ` Gabriel Scherer
2017-04-27 14:00 ` [Caml-list] Create Array of floats from string, surprise Jon Kleiser
2017-04-26 15:27 ` [Caml-list] Create Array of floats from string Alain Frisch
2017-04-27 8:36 ` Jon Kleiser
2017-04-27 9:15 ` Jon Kleiser [this message]
2017-04-28 12:19 ` Jon Kleiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E7AA81E4-D690-4F8F-8C22-87F5CF9575D8@mail.uio.no \
--to=jon.kleiser@ceres.no \
--cc=caml-list@inria.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox