From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail4-relais-sop.national.inria.fr (mail4-relais-sop.national.inria.fr [192.134.164.105]) by walapai.inria.fr (8.13.6/8.13.6) with ESMTP id p8H5NcnV032337 for ; Sat, 17 Sep 2011 07:23:38 +0200 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AikBAJstdE7RVdK2mGdsb2JhbAAnGoRVowQIFAEBAQEBCAkNBxQlgVMBAQEBAxICDx0BGx0BAwwGAwILDQICJgICIgERAQUBHAYTIodZJJdACop/QoJahG47iG0CAwaBJoQ7gREEh22LW4oTgm49g30 X-IronPort-AV: E=Sophos;i="4.68,397,1312149600"; d="scan'208";a="109404267" Received: from mail-iy0-f182.google.com ([209.85.210.182]) by mail4-smtp-sop.national.inria.fr with ESMTP/TLS/RC4-SHA; 17 Sep 2011 07:23:32 +0200 Received: by iadk27 with SMTP id k27so6459503iad.27 for ; Fri, 16 Sep 2011 22:23:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=cY353zf1ZWYJeapBPyDMOnFoiNAvOqpqa5HVz4JU9HE=; b=hO9VPssmpNiZAC5Wv/ZbuWr2as7nFH7cvxDVuk16lMfj8pBLRn/T8S+cqYMCQoD1vf qe8qz6wiQr2AK2ZYSmT13ESE1V6kRkHOYiufy7WN0ONtTzrm2/8YkGz68CxM6IeWj8zb 4xMTkUCuJI6/LFWJiVgEonv8uuVSK3qr6XZlI= MIME-Version: 1.0 Received: by 10.231.85.37 with SMTP id m37mr316492ibl.94.1316237011332; Fri, 16 Sep 2011 22:23:31 -0700 (PDT) Received: by 10.231.154.20 with HTTP; Fri, 16 Sep 2011 22:23:31 -0700 (PDT) In-Reply-To: <4E737745.2070205@dogguy.org> References: <4E737745.2070205@dogguy.org> Date: Sat, 17 Sep 2011 14:23:31 +0900 Message-ID: From: Jun Furuse To: Mehdi Dogguy Cc: caml-list Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by walapai.inria.fr id p8H5NcnV032337 Subject: Re: [Caml-list] A small patch for ocamlc 3.12.1 to find reudundant opens Done. http://caml.inria.fr/mantis/view.php?id=5357 J On Sat, Sep 17, 2011 at 1:20 AM, Mehdi Dogguy wrote: > On 09/16/2011 04:59 PM, Jun Furuse wrote: >> Hi, >> >> I have written a patch to detect redundant opens in OCaml source >> code, which is useful to keep your opened module list minimum. >> Keeping the list smaller is good to avoid name space contamination. >> > > It looks interesting. Thanks for your contribution ! Can you open a > bugreport on mantis [1] and attach the patch there? so that it doesn't > get lost. > > [1] http://caml.inria.fr/mantis/ > >> >> […] >> >> I have found nearly 150 redundant opens in OCaml source code! You >> should check your OCaml code with it, too! >> > > Interesting :) > > Kind regards, > > P.S.: fwiw, I didn't try it (yet). > > -- > Mehdi Dogguy مهدي الدڤي > http://dogguy.org/ >