From: bluestorm <bluestorm.dylc@gmail.com>
To: David Allsopp <dra-news@metastack.com>
Cc: W Dan Meyer <wojciech.meyer@googlemail.com>, caml-list@yquem.inria.fr
Subject: Re: [Caml-list] Converting variants with only constant constructors to integers
Date: Tue, 8 Jun 2010 09:59:55 +0200 [thread overview]
Message-ID: <AANLkTilku93HnpBpA6a3elkHX6u6lodPtPq7NFVKsV89@mail.gmail.com> (raw)
In-Reply-To: <013a01cb06de$32c6d930$98548b90$@romulus.metastack.com>
[-- Attachment #1: Type: text/plain, Size: 934 bytes --]
>
> Incidentally, the general function for getting a unique integer for a
> variant type with non-constant constructors isn't that bad either:
>
> let int_of_gen x =
> let x = Obj.repr x
> in
> if Obj.is_block x
> then -1 * Obj.tag x - 1
> else (Obj.magic x : int)
>
I consider that version much better. You could also write it in a more
restrictive way :
let to_int x =
let repr = Obj.repr x in
if Obj.is_int repr
then (Obj.obj repr : int)
else invalid_arg "to_int";;
The good point about those is that they check that the memory representation
is compatible before casting (while the "%identity" does not). They're
safer. Of course, they still break parametricity if used polymorphically, so
as you said type should be constrained.
I still would prefer the more direct pattern-matching definition : it may
require code generation not to be tedious, but the generated code is an
honourable OCaml citizen.
[-- Attachment #2: Type: text/html, Size: 1282 bytes --]
next prev parent reply other threads:[~2010-06-08 8:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-07 18:07 Török Edwin
2010-06-07 18:25 ` [Caml-list] " W Dan Meyer
2010-06-07 18:45 ` bluestorm
[not found] ` <87sk4y7lc7.fsf@gmail.com>
[not found] ` <4C0D3B0F.4060502@gmail.com>
2010-06-07 18:32 ` Török Edwin
2010-06-07 18:50 ` W Dan Meyer
2010-06-07 18:48 ` David Allsopp
2010-06-07 19:46 ` Török Edwin
2010-06-07 19:56 ` bluestorm
2010-06-07 22:51 ` W Dan Meyer
2010-06-08 7:42 ` David Allsopp
2010-06-08 7:59 ` bluestorm [this message]
2010-06-08 9:14 ` David Allsopp
2010-06-08 9:36 ` Luc Maranget
2010-06-08 9:45 ` David Allsopp
2010-06-08 9:51 ` Luc Maranget
2010-06-08 10:21 ` David Allsopp
2010-06-08 10:21 ` Dario Teixeira
2010-06-08 11:28 ` Kaustuv Chaudhuri
2010-06-08 11:40 ` bluestorm
2010-06-08 14:37 ` Jacques Garrigue
2010-06-08 18:22 ` Kaustuv Chaudhuri
2010-06-09 1:34 ` Jacques Garrigue
2010-08-23 14:36 ` Damien Doligez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTilku93HnpBpA6a3elkHX6u6lodPtPq7NFVKsV89@mail.gmail.com \
--to=bluestorm.dylc@gmail.com \
--cc=caml-list@yquem.inria.fr \
--cc=dra-news@metastack.com \
--cc=wojciech.meyer@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox