From: "Olivier Andrieu" <oandrieu@nerim.net>
To: "Richard Jones" <rich@annexia.org>
Cc: caml-list@inria.fr
Subject: Re: [Caml-list] Bug in Filename.basename?
Date: Wed, 5 Sep 2007 14:10:06 +0200 [thread overview]
Message-ID: <95513600709050510v4be7f21dpd3a9df75fb8c4bce@mail.gmail.com> (raw)
In-Reply-To: <20070905104127.GB24323@furbychan.cocan.org>
On 9/5/07, Richard Jones <rich@annexia.org> wrote:
> On Wed, Sep 05, 2007 at 06:45:38PM +1000, Erik de Castro Lopo wrote:
> > Hi all,
> >
> > I think I have found a bug in the above function.
> > Objective Caml version 3.10.0
> >
> > # let x = Filename.basename "a/b/c" ;;
> > val x : string = "c"
> > # let x = Filename.basename "a/b/c/" ;;
> > val x : string = "."
> >
> > The first result is fine, but second result is definitely not what
> > one would reasonably expect.
> >
> > For instance, the basename program in Linux gives:
> >
> > > basename a/b/c/
> > c
>
> I think the OCaml one is what I'd reasonably expect actually.
>
> The GNU documentation for basename says:
>
> `basename' removes any leading directory components from NAME.
>
> and a/b/c/ are leading directory components.
POSIX has a precise definition of its basename() function:
http://www.opengroup.org/onlinepubs/009695399/functions/basename.html
and it indeed says that trailing / are to be removed.
--
Olivier
prev parent reply other threads:[~2007-09-05 12:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-05 8:45 Erik de Castro Lopo
2007-09-05 10:41 ` [Caml-list] " Richard Jones
2007-09-05 11:10 ` Erik de Castro Lopo
2007-09-05 11:25 ` Oliver Bandel
2007-09-05 12:00 ` Erik de Castro Lopo
2007-09-05 13:06 ` Markus E L
2007-09-05 20:39 ` Oliver Bandel
2007-09-05 21:03 ` Oliver Bandel
2007-09-06 4:52 ` skaller
2007-09-06 7:09 ` Christophe Raffalli
2007-09-06 9:51 ` Oliver Bandel
2007-09-06 9:32 ` Markus E L
2007-09-06 10:00 ` Oliver Bandel
2007-09-05 12:15 ` Mattias Engdegård
2007-09-05 20:54 ` Oliver Bandel
2007-09-05 12:37 ` Brian Hurt
2007-09-05 13:06 ` Markus E L
2007-09-05 12:10 ` Olivier Andrieu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95513600709050510v4be7f21dpd3a9df75fb8c4bce@mail.gmail.com \
--to=oandrieu@nerim.net \
--cc=caml-list@inria.fr \
--cc=rich@annexia.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox