From: "Török Edwin" <edwintorok@gmail.com>
To: caml-list@inria.fr
Subject: Re: [Caml-list] Interfacing with C: bad practice
Date: Tue, 16 Aug 2011 13:17:28 +0300 [thread overview]
Message-ID: <4E4A43B8.8030306@gmail.com> (raw)
In-Reply-To: <CAMT7qiQRDing=NBNzar+kEzbpDj9e5=v_EOe7+4GdcMKph=Njw@mail.gmail.com>
On 08/16/2011 12:53 PM, Dmitry Bely wrote:
> On Tue, Aug 16, 2011 at 1:46 PM, <rixed@happyleptic.org> wrote:
>> -[ Tue, Aug 16, 2011 at 11:43:24AM +0300, Török Edwin ]----
>>> 'list' should be reachable via caml_local_roots, so if it really gets an invalid value
>>> it sounds like a bug to me.
>>
>> list may not be garbage collected (since it is indeed registered as the
>> root), but it may be moved arround (ie promoted to major heap).
>> The address of list would be fixed in the local variable (the root) but
>> not the transiant copy on the stack.
>> Maybe that's the actual problem ?
>
> Exactly. List is moved but its stack copy (wrp_ml_cons 2nd parameter)
> is not updated and holds an old address.
Ah yes.
So a best practice would be to always use a temporary variable
registered with CAMLlocal* when you call a function that can potentially invoke the GC?
(in your example to store the result of caml_copy_string).
Best regards,
--Edwin
next prev parent reply other threads:[~2011-08-16 10:17 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-16 7:37 Dmitry Bely
2011-08-16 8:04 ` Török Edwin
2011-08-16 8:25 ` Dmitry Bely
2011-08-16 8:43 ` Török Edwin
2011-08-16 9:46 ` rixed
2011-08-16 9:53 ` Dmitry Bely
2011-08-16 10:17 ` Török Edwin [this message]
2011-08-16 11:04 ` rixed
[not found] ` <20110816.105738.246515733851238101.Christophe.Troestler@umons.ac.be>
2011-08-16 9:21 ` Dmitry Bely
2011-08-16 10:39 ` Mauricio Fernandez
2011-08-16 14:27 ` John Carr
2011-08-16 12:28 ` [Caml-list] " Dmitry Bely
2011-08-16 15:25 ` [Caml-list] " Richard W.M. Jones
2011-08-16 15:51 ` rixed
2011-08-16 16:00 ` Will M. Farr
2011-08-16 16:10 ` Richard W.M. Jones
2011-08-16 16:17 ` Richard W.M. Jones
2011-08-16 16:18 ` Dmitry Bely
2011-08-16 16:22 ` Richard W.M. Jones
2011-08-16 16:27 ` Richard W.M. Jones
2011-08-16 16:30 ` malc
2011-08-16 16:34 ` Török Edwin
2011-08-16 16:47 ` Richard W.M. Jones
2011-08-16 16:55 ` [Caml-list] " Jeffrey Scofield
2011-08-16 17:08 ` Will M. Farr
2011-08-16 19:46 ` Gerd Stolpmann
2011-08-16 20:18 ` Jeffrey Scofield
2011-08-16 17:08 ` [Caml-list] " rixed
2011-08-16 16:06 ` John Carr
2011-08-16 16:14 ` Wojciech Meyer
2011-08-16 16:13 ` Dmitry Bely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E4A43B8.8030306@gmail.com \
--to=edwintorok@gmail.com \
--cc=caml-list@inria.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox