From: John Whitington <john@coherentgraphics.co.uk>
To: Jamie Brandon <jamie@scattered-thoughts.net>
Cc: caml-list@yquem.inria.fr
Subject: Re: [Caml-list] Causes for segfaults
Date: Mon, 15 Nov 2010 18:17:15 +0000 [thread overview]
Message-ID: <4CE1792B.3050603@coherentgraphics.co.uk> (raw)
In-Reply-To: <AANLkTimhKsAnR78N0pR2QwN7wrQ4-KbHbAyrrX1ihOPp@mail.gmail.com>
Hi,
On 15/11/2010 17:58, Jamie Brandon wrote:
> I do feel that this would have been much easier to fix if ocaml raised
> more informative errros. The change to Array.make and String.make to
> raise exceptions instead of segfaulting is welcome. Is there a way to
> cause stack overflows to raise exceptions in native compiled ocaml as
> well?
Excessive recursion of a function does raise an exception, on most
platforms, doesn't it?
However, this doesn't seem to be the case with excessive nested
exceptions. I got caught by this the other day:
let rec lex_stream i acc =
try lex_stream i (lex_next i::acc) with LexingEnd -> rev acc
(I had been replacing option types with exceptions in some places for
speed and wasn't concentrating...)
This segfaults on OS X Intel with OCaml 3.12.0 on large inputs.
The workaround is to add a null constructor for the type e.g LexNone. In
the absence of one, I think you have to do:
let rec lex_stream i acc =
match try Some (lex_stream i) with LexingEnd -> None with
| None -> rev acc
| Some s -> lex_stream i (a::acc)
Hopefully that option type doesn't slow things down too much.
Cheers,
--
John Whitington
Director, Coherent Graphics Ltd
http://www.coherentpdf.com/
next prev parent reply other threads:[~2010-11-15 18:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-04 20:19 Jamie Brandon
2010-11-04 20:25 ` [Caml-list] " Raphael Proust
2010-11-04 20:39 ` Jamie Brandon
2010-11-05 15:54 ` David MENTRE
2010-11-05 22:18 ` oliver
2010-11-04 20:41 ` Till Varoquaux
2010-11-05 23:14 ` Jamie Brandon
[not found] ` <384325291.294734.1288998871132.JavaMail.root@zmbs3.inria.fr>
2010-11-06 2:51 ` Daniel de Rauglaudre
2010-11-08 14:26 ` Jamie Brandon
2010-11-08 14:48 ` Till Varoquaux
2010-11-10 15:52 ` Jamie Brandon
2010-11-15 17:58 ` Jamie Brandon
2010-11-15 18:17 ` John Whitington [this message]
2010-11-15 18:38 ` Jamie Brandon
2010-11-15 21:47 ` Török Edwin
[not found] ` <157788745.568057.1289846305435.JavaMail.root@zmbs3.inria.fr>
2010-11-15 18:50 ` Daniel de Rauglaudre
2010-11-15 19:00 ` Anil Madhavapeddy
2010-11-15 19:08 ` Norman Hardy
[not found] ` <1795362267.568432.1289847605872.JavaMail.root@zmbs3.inria.fr>
2010-11-15 19:21 ` Daniel de Rauglaudre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE1792B.3050603@coherentgraphics.co.uk \
--to=john@coherentgraphics.co.uk \
--cc=caml-list@yquem.inria.fr \
--cc=jamie@scattered-thoughts.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox