From: "\"Stanisław T. Findeisen\"" <sf181257@gmail.com>
To: Yoriyuki Yamagata <yoriyuki.y@gmail.com>
Cc: Caml List <caml-list@inria.fr>
Subject: Re: [Caml-list] Balancing algorithm of Set/Map implementation
Date: Fri, 14 May 2010 20:48:35 +0200 [thread overview]
Message-ID: <4BED9B03.4080101@gmail.com> (raw)
In-Reply-To: <AANLkTinsY7jolgDDbHvhduK52-d7u21nVLJfPb5eNbUq@mail.gmail.com>
On 2010-05-14 08:17, Yoriyuki Yamagata wrote:
> When I read the balancing function of stdlib's Set/Map several years
> ago, I thought I have understand how it works. But now, I read it again
> and I'm less confident now. Could someone answer my questions? Here is
> the snippet of the code.
>
> let bal l v r =
> let hl = match l with Empty -> 0 | Node(_,_,_,h) -> h in
> let hr = match r with Empty -> 0 | Node(_,_,_,h) -> h in
> if hl > hr + 2 then begin
> match l with
>
> Empty -> invalid_arg "Set.bal"
> | Node(ll, lv, lr, _) ->
> if height ll >= height lr then
> create ll lv (create lr v r)
> else begin
> match lr with
>
> Empty -> invalid_arg "Set.bal"
> | Node(lrl, lrv, lrr, _)->
> create (create ll lv lrl) lrv (create lrr v r)
> end
> end else if hr > hl + 2 then begin
>
> match r with
> Empty -> invalid_arg "Set.bal"
> | Node(rl, rv, rr, _) ->
> if height rr >= height rl then
> create (create l v rl) rv rr
> else begin
>
> match rl with
> Empty -> invalid_arg "Set.bal"
> | Node(rll, rlv, rlr, _) ->
> create (create l v rll) rlv (create rlr rv rr)
> end
>
> end else
> Node(l, v, r, (if hl >= hr then hl + 1 else hr + 1))
[...]
> Another question is that why OCaml implementation allows
> a balancing factor up to *2*, which is usually allowed only up to 1?
I guess the balancing factor of -2/+2 can only occur temporarily
during insert/delete operations (and such). See for instance (set.ml):
let rec add x = function
Empty -> Node(Empty, x, Empty, 1)
| Node(l, v, r, _) as t ->
let c = Ord.compare x v in
if c = 0 then t else
if c < 0 then bal (add x l) v r else bal l v (add x r)
let rec remove x = function
Empty -> Empty
| Node(l, v, r, _) ->
let c = Ord.compare x v in
if c = 0 then merge l r else
if c < 0 then bal (remove x l) v r else bal l v (remove x r)
This is what bal is for: to fix the balance in the tree root.
I guess this: http://en.wikipedia.org/wiki/AVL_tree#Operations is
more or less correct. :-)
STF
http://eisenbits.homelinux.net/~stf/
OpenPGP: DFD9 0146 3794 9CF6 17EA D63F DBF5 8AA8 3B31 FE8A
prev parent reply other threads:[~2010-05-14 18:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-14 6:17 Yoriyuki Yamagata
[not found] ` <AANLkTikNr91FmeqOAXT-MOS0yDgH652WMvsg0a-WopKN@mail.gmail.com>
2010-05-14 8:09 ` Fwd: [Caml-list] " Julien Signoles
2010-05-14 13:02 ` Daniel Bünzli
2010-05-14 15:13 ` Goswin von Brederlow
2010-05-14 18:48 ` "Stanisław T. Findeisen" [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BED9B03.4080101@gmail.com \
--to=sf181257@gmail.com \
--cc=caml-list@inria.fr \
--cc=yoriyuki.y@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox