From: Martin Jambon <martin.jambon@ens-lyon.org>
To: David Rajchenbach-Teller <David.Teller@ens-lyon.org>
Cc: OCaml <caml-list@inria.fr>
Subject: Re: [Caml-list] Hiding private types
Date: Tue, 10 Feb 2009 19:05:19 +0100 [thread overview]
Message-ID: <4991C1DF.8010503@ens-lyon.org> (raw)
In-Reply-To: <1234286066.6457.35.camel@Blefuscu>
David Rajchenbach-Teller wrote:
> Dear list,
>
> I'm looking for a way to remove one or two annoyances of Batteries,
> which are related to private magic leaking into the type system and into
> the documentation.
>
>
>
> We define a module [IO] with, among other things, a type [output]. In
> fact, in order to avoid circular dependencies, [output] is actually
> defined in a private module [InnerIO], which lets other modules such as
> [ExtString] use [output] and still be used by [IO]. For instance,
> [ExtString] defines a function [print : InnerIO.output -> string ->
> unit].
>
> At a later stage, we pack [IO], [InnerIO], [ExtString] and others into a
> module [Extlib] and we later define a module [Batteries] containing
>
> module IO = Extlib.IO
> module String = ExtString.String
>
> etc.
>
>
> Now, all of this works. Unfortunately, the types visible by the user,
> either from the toplevel, from error messages or from -dannot, reveal
> too much from the inner workings of Batteries.
>
> For instance, [InnerIO], as implied by the name, is private. The
> existence of this module should not be visible by the user.
> Unfortunately, on the toplevel, we have
>
> # String.print;;
> - : Extlib.InnerIO.output -> string -> unit = <fun>
>
> Two abstractions have leaked out:
> * the existence of [InnerIO]
> * the existence of [Extlib]
>
> I would rather have
>
> # String.print;;
> - : IO.output -> string -> unit = <fun>
>
> or, at worst
>
> # String.print;;
> - : Batteries.IO.output -> string -> unit = <fun>
>
>
> Does anyone have an idea of how we could/should do this?
It looks like you can applying a signature to Batteries.IO does the trick:
(* IO's signature *)
module type A_sig =
sig
type t
val add : t -> t -> t
val create : unit -> t
end
(* Extlib.IO *)
module A : A_sig =
struct
type t = int
let add = ( + )
let create () = 1
end
(* Batteries.IO, version 1 *)
module B = A
(* Batteries.IO, version 2 *)
module C : A_sig = A
This is the problem that you're having, i.e. A.t appears in the error message:
# B.create () = 1;;
Characters 14-15:
B.create () = 1;;
^
This expression has type int but is here used with type B.t = A.t
This looks better:
# C.create () = A.create ();;
Characters 14-25:
C.create () = A.create ();;
^^^^^^^^^^^
This expression has type A.t but is here used with type C.t
I just hope it works for your problem.
Martin
--
http://mjambon.com/
next prev parent reply other threads:[~2009-02-10 18:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-10 17:14 David Rajchenbach-Teller
2009-02-10 18:05 ` Martin Jambon [this message]
2009-02-10 18:24 ` [Caml-list] " David Rajchenbach-Teller
2009-02-10 18:14 ` Daniel Bünzli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4991C1DF.8010503@ens-lyon.org \
--to=martin.jambon@ens-lyon.org \
--cc=David.Teller@ens-lyon.org \
--cc=caml-list@inria.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox