Mailing list for all users of the OCaml language and system.
 help / color / mirror / Atom feed
From: Brian Hurt <bhurt@janestcapital.com>
To: Till Varoquaux <till.varoquaux@gmail.com>
Cc: Nicolas Pouillard <nicolas.pouillard@gmail.com>,
	tmp123 <tmp123@menta.net>, caml-list <caml-list@inria.fr>
Subject: Re: [Caml-list] log function without evaluate arguments
Date: Tue, 06 Nov 2007 13:49:15 -0500	[thread overview]
Message-ID: <4730B72B.3000109@janestcapital.com> (raw)
In-Reply-To: <9d3ec8300711061040l424aac69y4b859a029d815089@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 948 bytes --]

Till Varoquaux wrote:

>Actually it doesn't:
>
>   log (lazy (Printf.printf "%s" (awfully_long_computation ())))
>
>when log_val is false (or sylvain's solution, which I prefer), will
>not behave like
>
>   Printf.ifprinf "%s" (awfully_long_computation ())
>
>(it won't evaluate its arguments).
>
>Till
>  
>
IMHO: evaluating the arguments of your log statement will avoid some 
really ugly heisenbugs- what if awfully_long_computation performs I/O or 
otherwise has side effects?.  Note that having side-effects in your 
arguments to the log statements is a really bad idea, but people will do 
it, and finding where they do it is non-trivial.

Also, creating a lazy thunk in Ocaml is expensive (like 140+ clock 
cycles), while passing an argument into a function is cheap- and the 
common case will be that the argument won't need to be evaluated, just 
passed in.

Translation: don't try to be too clever to avoid evaluating arguments.

Brian



[-- Attachment #2: Type: text/html, Size: 1334 bytes --]

  reply	other threads:[~2007-11-06 18:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-06 17:05 tmp123
2007-11-06 16:57 ` Sylvain Le Gall
2007-11-06 18:25 ` [Caml-list] " Nicolas Pouillard
2007-11-06 18:40   ` Till Varoquaux
2007-11-06 18:49     ` Brian Hurt [this message]
2007-11-07  3:39       ` Christopher L Conway
2007-11-07  4:00         ` Erik de Castro Lopo
2007-11-07  4:10           ` Christopher L Conway
2007-11-07 13:42             ` Brian Hurt
2007-11-07 10:21     ` Nicolas Pouillard
2007-11-07  3:40 ` Christopher L Conway
     [not found] ` <4a051d930711061938u25836a85ud28c610312e5896f@mail.gmail.com>
2007-11-07 10:31   ` tmp123

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4730B72B.3000109@janestcapital.com \
    --to=bhurt@janestcapital.com \
    --cc=caml-list@inria.fr \
    --cc=nicolas.pouillard@gmail.com \
    --cc=till.varoquaux@gmail.com \
    --cc=tmp123@menta.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox