From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on yquem.inria.fr X-Spam-Level: * X-Spam-Status: No, score=1.6 required=5.0 tests=AWL,SPF_SOFTFAIL autolearn=disabled version=3.1.3 Received: from concorde.inria.fr (concorde.inria.fr [192.93.2.39]) by yquem.inria.fr (Postfix) with ESMTP id CF34ABC69 for ; Fri, 23 Feb 2007 21:40:21 +0100 (CET) Received: from smtp.janestcapital.com (www.janestcapital.com [66.155.124.107]) by concorde.inria.fr (8.13.6/8.13.6) with ESMTP id l1NKeKjJ003750 for ; Fri, 23 Feb 2007 21:40:21 +0100 Received: from [192.168.250.217] [209.213.205.130] by janestcapital.com with ESMTP (SMTPD-9.10) id A133029C; Fri, 23 Feb 2007 15:40:19 -0500 Message-ID: <45DF5132.8030906@gnu.org> Date: Fri, 23 Feb 2007 15:40:18 -0500 From: Sam Steingold User-Agent: Thunderbird 1.5.0.8 (X11/20061107) MIME-Version: 1.0 To: Jon Harrop Cc: caml-list@yquem.inria.fr Subject: Re: warning on value shadowing References: <45DCAE89.1050904@gnu.org> <200702212225.16952.jon@ffconsultancy.com> In-Reply-To: <200702212225.16952.jon@ffconsultancy.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Miltered: at concorde with ID 45DF5134.001 by Joe's j-chkmail (http://j-chkmail . ensmp . fr)! X-Spam: no; 0.00; foo:01 quux:01 foo:01 quux:01 compiler:01 intentional:01 wrote:01 wrote:01 define:01 compiling:02 gnu:03 style:93 annoying:06 sds:07 warned:08 Jon Harrop wrote: > On Wednesday 21 February 2007 20:41, Sam Steingold wrote: >> Proposal: >> When both foo.ml and bar.ml define zot and quux.ml opens both Foo and >> Bar, there should be a warning (when compiling quux) about Foo.zot being >> shadowed by Bar.zot (or vice versa, depending on the order of the open >> statements). > > I think this is such a common style (I use shadowing deliberately all the > time) that it would be very annoying to be warned about it. of course there should be a way to tell the compiler that the shadowing is intentional.