From: Xavier Leroy <Xavier.Leroy@inria.fr>
To: Bardur Arantsson <spam@scientician.net>
Cc: caml-list@inria.fr
Subject: Re: [Caml-list] Re: announce: callbacks-0.1
Date: Sat, 10 Sep 2005 09:04:50 +0200 [thread overview]
Message-ID: <43228592.1040800@inria.fr> (raw)
In-Reply-To: <dfra5e$nlc$1@sea.gmane.org>
> From the implementation in globroots.c it would seem that
> register_global_root is at least O(n) in the number of roots, and that
> it has a large constant overhead compared to e.g. adding something to a
> hashtable.
You should look harder. register_global_root is insertion in a skip
list, which is probabilistic O(log n) with a low constant. I don't
think a hash table would perform significantly better for the mix of
operations we need to do on the set of global roots (insertion,
deletion, and enumeration for the GC).
> That depends hugely on what kind of library you're wrapping. I did a
> wrapper for libevent (events on file descriptors and other similar stuff
> like alarms, etc.) and what ended up happening was that a 1) lot of the
> time a relatively large amount of callbacks were registered, orm 2)
> callbacks would be registered/unregistered a lot. I did try using
> *_global_roots in my libevent wrapper, but the performance was awful
> until I changed it to use an (fd->callback) hashtable on the OCaml side.
I would have been very interested in a profiling of your initial
implementation. The only reason why the Caml hashtable can beat the
global roots is that the latter are not generational: since the
contents of registered global roots can change at any time without
notifying the GC, all global roots must be scanned at every minor
collection.
- Xavier Leroy
next prev parent reply other threads:[~2005-09-10 7:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-08 16:31 Christophe Raffalli
[not found] ` <4320A68E.1060608@xs4all.nl>
2005-09-08 21:24 ` [Caml-list] " Christophe Raffalli
2005-09-08 23:31 ` Bardur Arantsson
2005-09-09 6:30 ` Bardur Arantsson
2005-09-10 7:04 ` Xavier Leroy [this message]
2005-09-10 7:31 ` Bardur Arantsson
2005-09-10 13:04 ` [Caml-list] " Yaron Minsky
2005-09-10 21:02 ` caml_register_unmutable_global_root Christophe Raffalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43228592.1040800@inria.fr \
--to=xavier.leroy@inria.fr \
--cc=caml-list@inria.fr \
--cc=spam@scientician.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox