From: "Sébastien Hinderer" <Sebastien.Hinderer@inria.fr>
To: Gerd Stolpmann <info@gerd-stolpmann.de>
Cc: caml-list@inria.fr
Subject: Re: [Caml-list] ocamlnat
Date: Mon, 18 Jul 2016 10:14:18 +0200 [thread overview]
Message-ID: <20160718081418.GC2109@pl-59055.rocqadm.inria.fr> (raw)
In-Reply-To: <1468594034.25014.129.camel@e130.lan.sumadev.de>
Hi Gerd,
Gerd Stolpmann (2016/07/15 16:47 +0200):
> In deed, the native toplevel seems to run fine. So far I made the
> following adjustments in my repo:
>
> - renamed the modules so that the same names as for the bytecode
> version are used (e.g. Opttoploop becomes just Toploop)
> - added the missing definitions so that the interfaces are
> identical to the bytecode version
[...]
> - there was a bug that -linkall was not set when the cmxs files
> were on-the-fly generated
> - I also changed the error paths a little bit so that ocamlnat
> no longer crashes when a symbol isn't found. The error paths
> probably require more work.
I find all this awesome, thanks a lot for this work.
> It is interesting that only very little work was needed to get there.
> I'll test that more out in the next days, and I think there will be a PR
> soon.
I'd say, do not hesitate to split your work in several (smaller) PRs if
that makes sense. The smaller the PR, the easier the review process.
Sébastien.
prev parent reply other threads:[~2016-07-18 8:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 21:39 Gerd Stolpmann
2016-07-12 22:28 ` Gabriel Scherer
2016-07-13 9:50 ` Jeremie Dimino
2016-07-13 12:22 ` Gerd Stolpmann
2016-07-13 13:45 ` Fabrice Le Fessant
2016-07-14 19:26 ` Sébastien Hinderer
2016-07-15 14:47 ` Gerd Stolpmann
2016-07-18 8:14 ` Sébastien Hinderer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160718081418.GC2109@pl-59055.rocqadm.inria.fr \
--to=sebastien.hinderer@inria.fr \
--cc=caml-list@inria.fr \
--cc=info@gerd-stolpmann.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox