From: Hendrik Boom <hendrik@topoi.pooq.com>
To: caml-list@inria.fr
Subject: Re: [Caml-list] Suppress warning from within Ocaml source file
Date: Thu, 12 Nov 2015 15:16:07 -0500 [thread overview]
Message-ID: <20151112201607.GC30724@topoi.pooq.com> (raw)
In-Reply-To: <1447356106.28343.15.camel@zotac>
On Thu, Nov 12, 2015 at 08:21:46PM +0100, Gerd Stolpmann wrote:
> Am Donnerstag, den 12.11.2015, 19:39 +0100 schrieb Virgile Prevosto:
> > 2015-11-12 18:26 GMT+01:00 Daniel Bünzli <daniel.buenzli@erratique.ch>:
> > > Le jeudi, 12 novembre 2015 à 16:37, Leo White a écrit :
> > >> > This misses the point. By using `with` I can instruct the compiler that I don't want my program not to compile if I add or remove fields. In the current system I can do this with any update I want to make to a record except if for some strange reason that update happen to touch all the current fields of the record.
> > >>
> > >> I don't particularly wish to argue for or against using this warning, but I think it is worth noting
> > >> that this is not really any different from:
> > >
> > > […]
> > >
> > > It's quite different: you have dead code in your example.
> > >
> >
> > But in the record case, the expr in { expr with ... } will indeed be
> > evaluated (thus is not dead), but its result will never be used, which
> > is barely better. In the (admittedly contrived) example below,
> > investigating the cause of the warning would save you from a runtime
> > exception:
> >
> > type foo = { a : int; }
> > let rec x = lazy { a = (Lazy.force x).a }
> > let y = { (Lazy.force x) with a = 42 }
> >
> > Now that I think of it, it is more like warning 26, with the exception
> > that in the present case, the expression is usually a variable and
> > thus already evaluated.
>
> Maybe print the warning only in the non-variable case? And rephrase the
> warning to "the expression before 'with' is not evaluated"?
Isn't this message also misleading? Isn't the expression evaluated even
though its value ignored? This could show up f it has side effects.
-- hendr9ik
next prev parent reply other threads:[~2015-11-12 20:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 8:49 Soegtrop, Michael
2015-11-12 9:10 ` Gabriel Scherer
2015-11-12 9:33 ` Soegtrop, Michael
2015-11-12 9:44 ` Gabriel Scherer
2015-11-12 9:57 ` Soegtrop, Michael
2015-11-12 9:49 ` Daniel Bünzli
2015-11-12 12:21 ` Mr. Herr
2015-11-12 13:02 ` Soegtrop, Michael
2015-11-12 13:48 ` Daniel Bünzli
2015-11-12 14:54 ` Soegtrop, Michael
2015-11-12 15:14 ` Daniel Bünzli
2015-11-12 16:37 ` Leo White
2015-11-12 17:26 ` Daniel Bünzli
2015-11-12 18:39 ` Virgile Prevosto
2015-11-12 19:21 ` Gerd Stolpmann
2015-11-12 20:16 ` Hendrik Boom [this message]
2015-11-12 19:34 ` Jeremy Yallop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151112201607.GC30724@topoi.pooq.com \
--to=hendrik@topoi.pooq.com \
--cc=caml-list@inria.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox