Re: [Caml-list] Trivial compiler patches

[Goswin von Brederlow <goswin-v-b@web.de>]

On Sat, Mar 22, 2014 at 09:28:29AM +0100, Gabriel Scherer wrote:
> Alternatively you could have sent a
> pull-request against github/ocaml/ocaml (as part of the ongoing "patch
> review experiment" http://alan.petitepomme.net/cwn/2014.02.04.html#2
> ), but I think the workflow is not much quicker (though there are
> command-line tools to make it faster).

Everyone that has never done this before should take a look. Github
has a "help" link that teaches you various steps and makes even first
time use verry easy.

In short you do the following:

1) Point your browser at github.com, log in (create an account if you
   don't have one) and search for ocaml [1].
2) click "fork" to make your own copy of the ocaml repository
3) clone your own ocaml repository (on your local machine)
4) edit, compile, test
5) commit the changes (on your local machine)
6) push changes back to github (now everyone can see them)
7) back to your browser, update the page for your own ocaml repository
   to see your changes appear
8) click "pull request", review the diff and click "create pull request"
9) wait for the pull request to be accepted

I prefer to make a fresh branch for every pull request and have those
then merged into my master branch that I use locally. But that is up
to you. The github frontend keeps track of your pull requests and
tells you when it got merged and makes it easy to remove the pull
request branches once they are obsolete. The extra branch also makes
it easier to rebase patches in case they need to be updated.

I only recently made my first pull request via github and found it
amazingly simple and comfortable to use.

MfG
	Goswin

PS: you do 1-3 only once, 4-6 all the time as you develope your patch
and 8 once for every patch you want to submitt.

--

[1] https://github.com/ocaml/ocaml