From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on yquem.inria.fr X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=disabled version=3.1.3 Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) by yquem.inria.fr (Postfix) with ESMTP id D8248BBAF for ; Sun, 5 Oct 2008 02:04:47 +0200 (CEST) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AlsBANah50hA6ba5k2dsb2JhbACBcU2QZj4BAQEBCQkKCREDnlGGGAEC X-IronPort-AV: E=Sophos;i="4.33,362,1220220000"; d="scan'208";a="15669203" Received: from nf-out-0910.google.com ([64.233.182.185]) by mail2-smtp-roc.national.inria.fr with ESMTP; 05 Oct 2008 02:04:39 +0200 Received: by nf-out-0910.google.com with SMTP id b11so1030542nfh.13 for ; Sat, 04 Oct 2008 17:04:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:organization:to:subject:date :user-agent:references:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:message-id:from; bh=6UPk9VoFW+Hss5DnPKPnyqgOsaha5Q9hZ8d+VGCbYFU=; b=b0a2hjJzLR8Ju+++Iy6uVa9mHbjzrPazfOm6sltabmMj5tkhKfXty7kGwfOic/+Idy 79TTcOjWfwYI9Lll1+nT7dM0AcoWPThbWoAeTx+uHHH49wRNI/ByhuA1C+z9ieRd66OL y3/8fQB4v7uTbUes59B4wkC491CEl4YM8OojA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=organization:to:subject:date:user-agent:references:in-reply-to :mime-version:content-type:content-transfer-encoding :content-disposition:message-id:from; b=VxVxRBlUuENH7Jlo8opAPZW50TrHZ4a6s5j4zfeVNyJdQU2xwi0NjAIrfFXojx5Plj MNEdi1VQv+HTO/mFtJvrUDp+atiRnc/9MFzkyUaxb+40tfyeIDt7IR6CmgV9Zuhjt3+R 1woBefl8xSLDjqrjm9QygwM4cvRf/PsAZxGxY= Received: by 10.210.131.6 with SMTP id e6mr3822643ebd.10.1223165079516; Sat, 04 Oct 2008 17:04:39 -0700 (PDT) Received: from leper.local (host86-139-250-145.range86-139.btcentralplus.com [86.139.250.145]) by mx.google.com with ESMTPS id u14sm3060579gvf.6.2008.10.04.17.04.37 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 04 Oct 2008 17:04:38 -0700 (PDT) Organization: Flying Frog Consultancy Ltd. To: caml-list@yquem.inria.fr Subject: Re: [Caml-list] Metaprogramming features Date: Sun, 5 Oct 2008 02:05:36 +0100 User-Agent: KMail/1.9.9 References: <48E62D5B.3060400@mcmaster.ca> <200810042041.35499.jon@ffconsultancy.com> <20081004190416.GA6466@annexia.org> In-Reply-To: <20081004190416.GA6466@annexia.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200810050205.36703.jon@ffconsultancy.com> From: Jon Harrop X-Spam: no; 0.00; 0100,:01 trivial:01 syntax:01 afaik:01 frog:98 wrote:01 wrote:01 maintainer:01 caml-list:01 diff:02 caml:02 kernel:02 patches:03 patches:03 redhat:03 On Saturday 04 October 2008 20:04:16 Richard Jones wrote: > On Sat, Oct 04, 2008 at 08:41:35PM +0100, Jon Harrop wrote: > > I submitted the following trivial fix over a year ago: > > > > http://caml.inria.fr/mantis/view.php?id=4338 > > This makes the mistake of supplying a lump of code instead of a patch. > It's a very common mistake, so don't feel bad about it. I don't think it is a mistake in this context because my patch could not have been applied. > In fact it > happens so much with libvirt that I cowrote the following section to > cover it: > > http://et.redhat.com/~rjones/how-to-supply-code-to-open-source-projects/#pa >tches > > Rich. > > ObComment: People at Red Hat deal with patches almost as a form of > currency. Typically I'll send and receive a dozen patches a day, and > the kernel developers probably deal with ten times as many. The > interesting thing is that the actual diff / patch format is very > crude. It's crying out for someone to invent a tool which actually > understands the syntax of the code in the files (not just as plain > text) and creates a more robust and easier to read format. Suppling a patch certainly makes perfect sense when the maintainer can just apply the patch upstream but, AFAIK, that is not the case here. -- Dr Jon Harrop, Flying Frog Consultancy Ltd. http://www.ffconsultancy.com/?e