From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on yquem.inria.fr X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=AWL autolearn=disabled version=3.1.3 Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by yquem.inria.fr (Postfix) with ESMTP id 9A9BDBBAF for ; Sat, 4 Oct 2008 21:04:18 +0200 (CEST) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AhUDAMZa50jAXQIniGdsb2JhbACTYQEBARUipSWBaA X-IronPort-AV: E=Sophos;i="4.33,361,1220220000"; d="scan'208";a="17662374" Received: from concorde.inria.fr ([192.93.2.39]) by mail3-smtp-sop.national.inria.fr with ESMTP; 04 Oct 2008 21:04:18 +0200 Received: from mail1-relais-roc.national.inria.fr (mail1-relais-roc.national.inria.fr [192.134.164.82]) by concorde.inria.fr (8.13.6/8.13.6) with ESMTP id m94J4HZI002363 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=OK) for ; Sat, 4 Oct 2008 21:04:18 +0200 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AhUDABJb50hQRFuwiGdsb2JhbACTYQEBARUipSCBaA X-IronPort-AV: E=Sophos;i="4.33,361,1220220000"; d="scan'208";a="18214797" Received: from furbychan.cocan.org ([80.68.91.176]) by mail1-smtp-roc.national.inria.fr with ESMTP/TLS/AES256-SHA; 04 Oct 2008 21:04:17 +0200 Received: from rich by furbychan.cocan.org with local (Exim 4.63) (envelope-from ) id 1KmCQK-0001kH-Vh for caml-list@inria.fr; Sat, 04 Oct 2008 20:04:17 +0100 Date: Sat, 4 Oct 2008 20:04:16 +0100 To: caml-list@inria.fr Subject: Re: [Caml-list] Metaprogramming features Message-ID: <20081004190416.GA6466@annexia.org> References: <48E62D5B.3060400@mcmaster.ca> <200810041531.18370.jon@ffconsultancy.com> <20081004135715.GA29077@annexia.org> <200810042041.35499.jon@ffconsultancy.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200810042041.35499.jon@ffconsultancy.com> User-Agent: Mutt/1.5.13 (2006-08-11) From: Richard Jones X-Miltered: at concorde with ID 48E7BE31.000 by Joe's j-chkmail (http://j-chkmail . ensmp . fr)! X-Spam: no; 0.00; 0100,:01 trivial:01 syntax:01 wrote:01 caml-list:01 diff:02 caml:02 kernel:02 patches:03 patches:03 redhat:03 fix:05 inria:06 probably:07 red:92 On Sat, Oct 04, 2008 at 08:41:35PM +0100, Jon Harrop wrote: > I submitted the following trivial fix over a year ago: > > http://caml.inria.fr/mantis/view.php?id=4338 This makes the mistake of supplying a lump of code instead of a patch. It's a very common mistake, so don't feel bad about it. In fact it happens so much with libvirt that I cowrote the following section to cover it: http://et.redhat.com/~rjones/how-to-supply-code-to-open-source-projects/#patches Rich. ObComment: People at Red Hat deal with patches almost as a form of currency. Typically I'll send and receive a dozen patches a day, and the kernel developers probably deal with ten times as many. The interesting thing is that the actual diff / patch format is very crude. It's crying out for someone to invent a tool which actually understands the syntax of the code in the files (not just as plain text) and creates a more robust and easier to read format. -- Richard Jones Red Hat