Mailing list for all users of the OCaml language and system.
 help / color / mirror / Atom feed
From: Richard Jones <rich@annexia.org>
To: caml-list@inria.fr
Subject: Re: [Caml-list] Metaprogramming features
Date: Sat, 4 Oct 2008 20:04:16 +0100	[thread overview]
Message-ID: <20081004190416.GA6466@annexia.org> (raw)
In-Reply-To: <200810042041.35499.jon@ffconsultancy.com>

On Sat, Oct 04, 2008 at 08:41:35PM +0100, Jon Harrop wrote:
> I submitted the following trivial fix over a year ago:
> 
>   http://caml.inria.fr/mantis/view.php?id=4338

This makes the mistake of supplying a lump of code instead of a patch.
It's a very common mistake, so don't feel bad about it.  In fact it
happens so much with libvirt that I cowrote the following section to
cover it:

http://et.redhat.com/~rjones/how-to-supply-code-to-open-source-projects/#patches

Rich.

ObComment: People at Red Hat deal with patches almost as a form of
currency.  Typically I'll send and receive a dozen patches a day, and
the kernel developers probably deal with ten times as many.  The
interesting thing is that the actual diff / patch format is very
crude.  It's crying out for someone to invent a tool which actually
understands the syntax of the code in the files (not just as plain
text) and creates a more robust and easier to read format.

-- 
Richard Jones
Red Hat


  reply	other threads:[~2008-10-04 19:04 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-03 14:34 Jacques Carette
2008-10-03 15:09 ` [Caml-list] " Dario Teixeira
2008-10-04  2:00   ` Jon Harrop
2008-10-04  9:03     ` David Teller
2008-10-04 14:22       ` Jon Harrop
2008-10-06 14:06     ` Brian Hurt
2008-10-06 15:56       ` Jon Harrop
2008-10-06 16:46         ` Chung-chieh Shan
2008-10-07  0:17           ` [Caml-list] " Jon Harrop
2008-10-07 12:49             ` Nicolas Pouillard
2008-10-07 15:36               ` Jon Harrop
2008-10-07 16:31                 ` Jacques Carette
2008-10-03 16:01 ` [Caml-list] " David Teller
2008-10-03 21:14   ` Paolo Donadeo
2008-10-04  2:17   ` Jon Harrop
2008-10-04  9:10     ` David Teller
2008-10-04  0:49 ` Stefano Zacchiroli
2008-10-04  2:03   ` Jon Harrop
2008-10-04  8:23     ` Richard Jones
2008-10-04 14:31       ` Jon Harrop
2008-10-04 13:57         ` Richard Jones
2008-10-04 19:41           ` Jon Harrop
2008-10-04 19:04             ` Richard Jones [this message]
2008-10-05  1:05               ` Jon Harrop
2008-10-06 16:54               ` Chung-chieh Shan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081004190416.GA6466@annexia.org \
    --to=rich@annexia.org \
    --cc=caml-list@inria.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox