Mailing list for all users of the OCaml language and system.
 help / color / mirror / Atom feed
From: Alexandre Pilkiewicz <alexandre.pilkiewicz@polytechnique.org>
To: caml-list@yquem.inria.fr
Subject: Re: [Caml-list] Questions on replacing finalizers and memory	footprints
Date: Sat, 8 Dec 2007 10:57:54 +0100	[thread overview]
Message-ID: <200712081057.54605.alexandre.pilkiewicz@polytechnique.org> (raw)
In-Reply-To: <75D66E7E-2C71-40E3-8F94-129821A06FFA@x9c.fr>

Le Friday 07 December 2007 22:01:23 forum@x9c.fr, vous avez écrit :
> Le 7 déc. 07 à 20:54, Jean-Christophe Filliâtre a écrit :
> My mistake, I did not take into account the fact that if a block is
> moved by the
> garbage collector, its reference is updated in the hashtable *too*.
> Hence the termination guarantee.

I think the problem is with the hash function :

	let hash o = Hashtbl.hash (magic o : int)

If you put an object in the hash table, it is stored under a key that depends 
on it's address a1. Once it's moved by the GC to the address a2, its 
reference is changed to a2, but not its key which is still the hash of a1. So 
when you check after that if your object is allready in the hash table, you 
look under the key hash(a2) if it's allready there, but it's not ! And if you 
are very unlucky (and have very few memory), it might append several time.

One solution could be to store the objects in a normal list and to look at the 
entire list every time. It would be *much* slower on huge structures, but 
probably more "correct" (so if used only for debug purpose, why not..)

let node_list = ref []

let in_list o = List.memq o !node_list

let add_in_list o = node_list := o::!node_list

let reset_list () = node_list := []

-- 
Alexandre Pilkiewicz


  reply	other threads:[~2007-12-08 10:06 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-06 11:12 Thomas Fischbacher
2007-12-06 12:51 ` [Caml-list] " dmitry grebeniuk
2007-12-06 14:26 ` Richard Jones
2007-12-06 14:57   ` Thomas Fischbacher
2007-12-06 16:50     ` Jon Harrop
2007-12-06 21:33       ` forum
2007-12-07  8:52 ` Xavier Leroy
2007-12-07 10:44   ` Jean-Christophe Filliâtre
2007-12-07 10:35     ` Jon Harrop
2007-12-07 11:18     ` forum
2007-12-07 19:54       ` Jean-Christophe Filliâtre
2007-12-07 21:01         ` forum
2007-12-08  9:57           ` Alexandre Pilkiewicz [this message]
2007-12-08 14:20             ` Benjamin Canou
2007-12-07 20:31     ` Christophe Raffalli
2008-01-23 12:08     ` Hendrik Tews
2007-12-07 11:31   ` Berke Durak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200712081057.54605.alexandre.pilkiewicz@polytechnique.org \
    --to=alexandre.pilkiewicz@polytechnique.org \
    --cc=caml-list@yquem.inria.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox