From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (from majordomo@localhost) by pauillac.inria.fr (8.7.6/8.7.3) id QAA17016; Thu, 15 Jan 2004 16:42:16 +0100 (MET) X-Authentication-Warning: pauillac.inria.fr: majordomo set sender to owner-caml-list@pauillac.inria.fr using -f Received: from concorde.inria.fr (concorde.inria.fr [192.93.2.39]) by pauillac.inria.fr (8.7.6/8.7.3) with ESMTP id QAA17034 for ; Thu, 15 Jan 2004 16:42:14 +0100 (MET) Received: from aomori.annexia.org (annexia.force9.co.uk [212.56.101.183]) by concorde.inria.fr (8.11.1/8.11.1) with ESMTP id i0FFgD504577 for ; Thu, 15 Jan 2004 16:42:13 +0100 (MET) Received: from rich by aomori.annexia.org with local (Exim 3.36 #1 (Debian)) id 1Ah9dL-0002Ao-00; Thu, 15 Jan 2004 15:42:11 +0000 Date: Thu, 15 Jan 2004 15:42:11 +0000 To: Frederic van der Plancke Cc: caml-list@inria.fr Subject: Re: [Caml-list] ANNOUNCE: mod_caml 1.0.6 - includes security patch Message-ID: <20040115154211.GA8340@redhat.com> References: <20040115140324.GA3047@redhat.com> <4006AC01.F2AD2741@decis.be> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4006AC01.F2AD2741@decis.be> User-Agent: Mutt/1.5.4i From: Richard Jones X-Loop: caml-list@inria.fr X-Spam: no; 0.00; caml-list:01 2004:99 plancke:01 bugfixes:01 pcre:01 pcre:01 subst:01 subst:01 freshmeat:01 autoconf:01 automake:01 compiles:01 rpms:01 ltd:98 regexp:01 Sender: owner-caml-list@pauillac.inria.fr Precedence: bulk On Thu, Jan 15, 2004 at 04:04:33PM +0100, Frederic van der Plancke wrote: > Hi Richard, > > I see something strange with your patch: > > Richard Jones wrote: > [...] > > This is fixed in version 1.0.6, along with some other minor bugfixes, > > or you can apply the source patch at the end of this message. > [...] > > + let re1 = Pcre.regexp "'" in (* Double up any single quotes. *) > > + let sub1 = Pcre.subst "''" in > > + let re2 = Pcre.regexp "\\\\" in (* Double up any backslashes. *) > > + let sub2 = Pcre.subst "\\\\" in > > This does not look right: why sub2 = re2 and not sub2 = re2 ^ re2 ? No, it seems to be right. PCRE doesn't using \ escaping in substitutions, only in regular expressions. So the re2 matches \ and sub2 substitutes \\. Rich. -- Richard Jones. http://www.annexia.org/ http://freshmeat.net/users/rwmj Merjis Ltd. http://www.merjis.com/ - improving website return on investment MAKE+ is a sane replacement for GNU autoconf/automake. One script compiles, RPMs, pkgs etc. Linux, BSD, Solaris. http://www.annexia.org/freeware/makeplus/ ------------------- To unsubscribe, mail caml-list-request@inria.fr Archives: http://caml.inria.fr Bug reports: http://caml.inria.fr/bin/caml-bugs FAQ: http://caml.inria.fr/FAQ/ Beginner's list: http://groups.yahoo.com/group/ocaml_beginners