From: Jocelyn Serot <Jocelyn.Serot@lasmea.univ-bpclermont.fr>
To: caml-list@margaux.inria.fr
Subject: Re: native code compiler and exceptions
Date: Fri, 27 Sep 1996 14:46:35 METDST [thread overview]
Message-ID: <199609271244.OAA07980@concorde.inria.fr> (raw)
In his answer to my original question, P. Weis (Pierre.Weis@inria.fr) says:
> Wao! To ``rely heavily on array bounds violation'' is a very ugly style
> of programming. I could not imagine why you need to use this style.
Well, maybe the formulation ``rely heavily on array bounds violation'' was
a bit misleading. My code relies on the correct handling of exceptions that,
at the lowest level may be trapped as array bound violation.
I will try yo explain my pb on a small example.
Suppose that images are represented as pixel 2d-arrays (in fact, images
are implemented as ADTs, with their internal representation hidden).
# type image = int array array
# let get_pixel i y x = i.(y).(x)
# let set_pixel i y x p = i.(y).(x) <- p
# let create nr nc = Array.new_matrix nr nc 0
What i want to do is to compute, for example is a simple 2d-convolution,
turning pixel(x,y) into (p(x-1,y)+p(x,y-1)+p(x+1,y)+p(x,y+1))/4.
A possible manner to handle the clipping effect at image boundaries is to
set that p(x,y) = 0 whenever x<0 ot y<0.
So it does not seem to me so "ugly" to write my convolution fn like that:
# let conv im =
# let nr = nb_rows im and nc = nb_cols im in
# let im' = create nr nc in
# for y = 0 to pred nr do for x = 0 to pred nc do
# let p1 = try_get_pixel im (x-1) y 0 in
# let p2 = try_get_pixel im x (y-1) 0 in
# let p3 = try_get_pixel im (x+1) y 0 in
# let p4 = try_get_pixel im x (y+1) 0 in
# set_pixel im' (y,x) ((p1+p2+p3+p4)/4) done done;
# m'
making use of the given access fn:
# let try_get_pixel im y x clip =
# try get_pixel im y x with Invalid_argument _ -> clip
(btw, note that is this case clip might be a _fn_ of the "faulty" coordinates,
like:
# let try_get_pixel im y x clip =
# try get_pixel im y x with Invalid_argument _ -> clip y x
)
Is this not "good" fnal programming style ?..
Or does the "ugliness" lies only in the [... with Invalid_argument _ ->...]
construct ? In this case, i guess i should test _explicitely_ whether (y,x) are
in bounds instead of relying of the exception [Invalid_argument "Array.get"].Ie:
# let try_get_pixel im y x clip =
# if (y<0 || y>=(nb_rows im) || x<0 || x>=(nb_cols im)) then clip
# else get_pixel im y x
Is it what you mean ?
Jocelyn
--
E-mail: Jocelyn.Serot@lasmea.univ-bpclermont.fr .............................
S-mail: LASMEA - URA 1793 CNRS, Universite Blaise Pascal, 63177 Aubiere cedex
Tel: (33) 73.40.73.30 - Fax: (33) 73.40.72.62 ...............................
.... http://wwwlasmea.univ-bpclermont.fr/Personnel/Jocelyn.Serot/Welcome.html
next reply other threads:[~1996-09-27 15:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
1996-09-27 12:46 Jocelyn Serot [this message]
1996-09-27 15:58 ` Pierre Weis
[not found] <199609271524.RAA27638@pauillac.inria.fr>
1996-09-27 16:01 ` Jocelyn Serot
-- strict thread matches above, loose matches on Subject: below --
1996-09-27 13:04 Harrison R. Ulrich (contractor)
1996-09-27 16:03 ` Christophe Raffalli
1996-09-27 11:21 Jocelyn Serot
1996-09-27 11:41 ` Pierre Weis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199609271244.OAA07980@concorde.inria.fr \
--to=jocelyn.serot@lasmea.univ-bpclermont.fr \
--cc=caml-list@margaux.inria.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox