From: whitequark <whitequark@whitequark.org>
To: "François Pottier" <francois.pottier@inria.fr>
Cc: Drup <drupyog+caml@zoho.com>, caml-list@inria.fr
Subject: Re: [Caml-list] [ANN] visitors
Date: Tue, 31 Jan 2017 09:30:48 +0000 [thread overview]
Message-ID: <1115108d11d3bb3d740e191d00ed7ebc@whitequark.org> (raw)
In-Reply-To: <588F6415.4000900@inria.fr>
On 2017-01-30 16:04, François Pottier wrote:
>> A big difference is that it load type definition from .cmi files
>> directly.
>
> Indeed, a limitation of the ppx approach is that it is purely syntatic:
> a syntax tree (the type definition) is turned into a syntax tree (the
> definition of the visitor classes). In particular, at the moment,
> "visitors"
> cannot generate visitor classes for a pre-existing type. Perhaps one
> could
> write a tool that reads a .cmi file, but I suppose it would have to be
> explicitly invoked as an external tool. I will think about it.
I wrote this tool long ago, it's called ppx_import[1]. In fact it
motivated
some improvements to the compiler, chiefly the way to extract the set of
-I paths.
It's even linked from ppx_deriving README[2].
[1]: https://github.com/whitequark/ppx_import
[2]:
https://github.com/whitequark/ppx_deriving/#working-with-existing-types
--
whitequark
next prev parent reply other threads:[~2017-01-31 9:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-27 17:56 François Pottier
[not found] ` <fc83f6ab-90a1-8ac1-7585-a15fb7fe89bd@zoho.com>
2017-01-30 16:04 ` François Pottier
2017-01-30 16:18 ` François Pottier
2017-01-31 9:30 ` whitequark [this message]
2017-01-31 10:26 ` François Pottier
2017-01-31 21:02 ` whitequark
2017-01-31 12:46 ` François Pottier
2017-02-01 15:50 ` Emilio Jesús Gallego Arias
2017-02-01 16:48 ` François Pottier
2017-02-01 23:49 ` whitequark
2017-02-02 0:46 ` Emilio Jesús Gallego Arias
2017-03-16 11:12 ` Kakadu
2017-03-16 15:33 ` whitequark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1115108d11d3bb3d740e191d00ed7ebc@whitequark.org \
--to=whitequark@whitequark.org \
--cc=caml-list@inria.fr \
--cc=drupyog+caml@zoho.com \
--cc=francois.pottier@inria.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox